Skip to content

Redesign DevLoadingView (iOS) #58866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntie wants to merge 1 commit into from
+389 −105
Open

Redesign DevLoadingView (iOS) #58866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Utilities/DevLoadingView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const COLOR_SCHEME = {
textColor: '#242526',
},
refresh: {
backgroundColor: '#2584e8',
backgroundColor: '#1065AF',
textColor: '#ffffff',
},
error: {
Expand All @@ -33,7 +33,7 @@ const COLOR_SCHEME = {
textColor: '#ffffff',
},
refresh: {
backgroundColor: '#2584e8',
backgroundColor: '#1065AF',
textColor: '#ffffff',
},
error: {
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/Libraries/Utilities/HMRClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,8 @@ function setHMRUnavailableReason(reason: string) {
// the warning to native engineers who use cached bundles without Metro.
if (hmrClient.isEnabled() && didConnect) {
DevLoadingView.showMessage(
'Fast Refresh disconnected. Reload app to reconnect.',
// Keeps 'to reconnect.' together when the banner wraps.
'Fast Refresh disconnected. Reload app to\u00A0reconnect.',
'error',
{dismissButton: true},
);
Expand Down
Loading
Loading