Conversation
huntie
added this pull request to stack #58868
October 5, 2026 16:11
huntie
marked this pull request as ready for review
October 5, 2026 21:00
cipolleschi
reviewed
Oct 6, 2026
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
left some questions and nits
| // UIAlertController on iOS 27.1. | ||
| static CGFloat RCTDevLoadingViewAlertCenterOffset(UIEdgeInsets safeAreaInsets) | ||
| { | ||
| return 0.2818 * (safeAreaInsets.left - safeAreaInsets.right) / 2; |
Contributor
There was a problem hiding this comment.
what is this number?? it is oddly specific! xD
Also, safeAreaInsets.left - safeAreaInsets.right in most case will end up being 0... Problably only for the Duo it does return something that is not 0.
Comment on lines
+131
to
+133
| #if RCT_DEV_LOADING_VIEW_HAS_HINGE | ||
| [_divisionPollTimer invalidate]; | ||
| #endif |
Contributor
There was a problem hiding this comment.
why we need this only for the Duo?
Comment on lines
+219
to
+221
| ((RCTDevLoadingWindow *)self->_window).layoutHandler = ^{ | ||
| [weakSelf _updatePlacementAnimated:NO]; | ||
| }; |
Contributor
There was a problem hiding this comment.
rather then this ugly casting.. can we create the right window in a variable at line 211:
RCTDevLoadingWindow * devLoadingWindow = windowScene != nil ? [[RCTDevLoadingWindow alloc] initWithWindowScene:windowScene]
: [[RCTDevLoadingWindow alloc] init];
self->_window = devLoadingWindowso that here we only have to:
devLoadingWindow.layoutHandler = ^{
[weakSelf _updatePlacementAnimated:NO];
};This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dev loading banner spans the full width under the status bar. On iPhone Duo it collides with the rail and camera cutout, and it straddles the hinge when the device is partly folded.
On top of wider out-of-tree platform support since it was created (desktop, iPad, visionOS and more), this UI component was due a visual refresh.
This diff
Redesigns
<DevLoadingView>as a floating pill at the center-top of the screen.Key changes:
iPhone Duo platform nuances:
Why so much attention?
These updates + details help reinforce that React Native is maintained and high quality, and supports the iOS platform completely. Delighting the user (e.g. avoiding the iPhone Duo hinge like other system elements) is a goal.
Changelog:
[iOS][Changed] - Dev loading banner: Redesign in-app Loading/Fast Refresh banner
Test Plan
App states, iPhone 18 Pro
Note: This is RNTester's non-native header — regular headers sit a bit lower and generally align a bit better with the loading view vertically.
Disconnected
(Largest existing variant, stays visible until dismissed)
🎬 End to end app load, Fast Refresh
ios-pill-e2e-load-refresh-3.mov
🎬 Dynamic fold avoidance, iPhone Duo
Screen.Recording.2026-10-05.at.20.50.31.mov