Skip to content

test(clickhouse-driver, cohere, falcon, fastapi, fastmcp): Remove redundant empty data_collection from sentry_init #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericapisani wants to merge 2 commits into from
+0 −58
Open

test(clickhouse-driver, cohere, falcon, fastapi, fastmcp): Remove redundant empty data_collection from sentry_init #7907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf538f
test(clickhouse-driver, cohere, falcon, fastapi, fastmcp): Remove red…
ericapisani Oct 6, 2026
5ef4564
.
ericapisani Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/integrations/clickhouse_driver/test_clickhouse_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
def test_clickhouse_client_breadcrumbs(sentry_init, capture_events) -> None:
sentry_init(
integrations=[ClickhouseDriverIntegration()],
data_collection={},
)
events = capture_events()

Expand Down Expand Up @@ -418,7 +417,6 @@ def test_clickhouse_client_spans(
sentry_init(
integrations=[ClickhouseDriverIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("span")

Expand Down Expand Up @@ -547,7 +545,6 @@ def test_clickhouse_client_spans(
def test_clickhouse_dbapi_breadcrumbs(sentry_init, capture_events) -> None:
sentry_init(
integrations=[ClickhouseDriverIntegration()],
data_collection={},
)
events = capture_events()

Expand Down Expand Up @@ -650,7 +647,6 @@ def test_clickhouse_dbapi_spans(
sentry_init(
integrations=[ClickhouseDriverIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("span")

Expand Down Expand Up @@ -777,7 +773,6 @@ def test_span_origin(sentry_init, capture_items):
sentry_init(
integrations=[ClickhouseDriverIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("span")

Expand Down
4 changes: 0 additions & 4 deletions tests/integrations/cohere/test_cohere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,6 @@ def test_bad_chat(sentry_init, capture_items):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("event", "span")
Expand All @@ -401,7 +400,6 @@ def test_span_status_error(sentry_init, capture_items):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("span")

Expand All @@ -423,7 +421,6 @@ def test_span_origin_chat(sentry_init, capture_items):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("span")
Expand Down Expand Up @@ -459,7 +456,6 @@ def test_span_origin_embed(sentry_init, capture_items):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("span")
Expand Down
4 changes: 0 additions & 4 deletions tests/integrations/falcon/test_falcon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def test_has_context(
):
sentry_init(
integrations=[FalconIntegration()],
data_collection={},
)

client = make_client()
Expand Down Expand Up @@ -278,7 +277,6 @@ def test_falcon_large_json_request(
integrations=[FalconIntegration()],
max_request_body_size="always",
max_value_length=max_value_length,
data_collection={},
)

data = {"foo": {"bar": "a" * (1034)}}
Expand Down Expand Up @@ -361,7 +359,6 @@ def test_falcon_raw_data_request(
):
sentry_init(
integrations=[FalconIntegration()],
data_collection={},
)

class Resource:
Expand Down Expand Up @@ -626,7 +623,6 @@ def on_post(self, req, _):

sentry_init(
integrations=[FalconIntegration()],
data_collection={},
)

try:
Expand Down
5 changes: 0 additions & 5 deletions tests/integrations/fastapi/test_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ async def body_form(
async def test_request_info_json_body(sentry_init, capture_items):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
integrations=[StarletteIntegration()],
)

Expand Down Expand Up @@ -169,7 +168,6 @@ async def test_request_info_json_body(sentry_init, capture_items):
async def test_formdata_request_body(sentry_init, capture_items):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
max_request_body_size="always",
integrations=[StarletteIntegration()],
)
Expand Down Expand Up @@ -215,7 +213,6 @@ async def test_formdata_request_body(sentry_init, capture_items):
async def test_request_body_too_big(sentry_init, capture_items):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
integrations=[StarletteIntegration()],
)

Expand Down Expand Up @@ -343,7 +340,6 @@ async def test_response(sentry_init, capture_events):
sentry_init(
integrations=[StarletteIntegration(), FastApiIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

app = fastapi_app_factory()
Expand Down Expand Up @@ -729,7 +725,6 @@ def test_transaction_http_method_custom(sentry_init, capture_items):
def test_request_url(sentry_init, capture_items):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
integrations=[
StarletteIntegration(),
],
Expand Down
6 changes: 0 additions & 6 deletions tests/integrations/fastmcp/test_fastmcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,6 @@ async def test_fastmcp_tool_with_error(
sentry_init(
integrations=[MCPIntegration(), LoggingIntegration(event_level=logging.ERROR)],
traces_sample_rate=1.0,
data_collection={},
)

mcp = FastMCP("Test Server")
Expand Down Expand Up @@ -785,7 +784,6 @@ async def test_fastmcp_resource_sync(
sentry_init(
integrations=[MCPIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mcp = FastMCP("Test Server")
Expand Down Expand Up @@ -834,7 +832,6 @@ async def test_fastmcp_resource_async(sentry_init, capture_items, FastMCP, json_
sentry_init(
integrations=[MCPIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mcp = FastMCP("Test Server")
Expand Down Expand Up @@ -908,7 +905,6 @@ async def test_fastmcp_span_origin(
sentry_init(
integrations=[MCPIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mcp = FastMCP("Test Server")
Expand Down Expand Up @@ -950,7 +946,6 @@ def test_fastmcp_http_transport(sentry_init, capture_items, FastMCP, json_rpc):
sentry_init(
integrations=[MCPIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mcp = FastMCP("Test Server")
Expand Down Expand Up @@ -1014,7 +1009,6 @@ async def test_fastmcp_stdio_transport(
sentry_init(
integrations=[MCPIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mcp = FastMCP("Test Server")
Expand Down
13 changes: 0 additions & 13 deletions tests/integrations/google_genai/test_google_genai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,6 @@ def test_error_handling(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("event")

Expand Down Expand Up @@ -658,7 +657,6 @@ def test_span_origin(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mock_http_response = create_mock_http_response(EXAMPLE_API_RESPONSE_JSON)
Expand Down Expand Up @@ -687,7 +685,6 @@ def test_response_without_usage_metadata(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# Response without usage metadata
Expand Down Expand Up @@ -807,7 +804,6 @@ def test_all_configuration_parameters(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mock_http_response = create_mock_http_response(EXAMPLE_API_RESPONSE_JSON)
Expand Down Expand Up @@ -851,7 +847,6 @@ def test_empty_response(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# Minimal response with empty candidates array
Expand Down Expand Up @@ -885,7 +880,6 @@ def test_response_with_different_id_fields(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# Response with response_id and model_version
Expand Down Expand Up @@ -928,7 +922,6 @@ def test_tool_with_async_function(sentry_init):
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# Create an async tool function
Expand Down Expand Up @@ -1280,7 +1273,6 @@ def test_embed_content_error_handling(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("event")

Expand Down Expand Up @@ -1312,7 +1304,6 @@ def test_embed_content_without_statistics(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# Response without statistics (typical for older google-genai versions)
Expand Down Expand Up @@ -1356,7 +1347,6 @@ def test_embed_content_span_origin(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mock_http_response = create_mock_http_response(EXAMPLE_EMBED_RESPONSE_JSON)
Expand Down Expand Up @@ -1564,7 +1554,6 @@ async def test_async_embed_content_error_handling(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("event")

Expand Down Expand Up @@ -1597,7 +1586,6 @@ async def test_async_embed_content_without_statistics(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# Response without statistics (typical for older google-genai versions)
Expand Down Expand Up @@ -1644,7 +1632,6 @@ async def test_async_embed_content_span_origin(
sentry_init(
integrations=[GoogleGenAIIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

mock_http_response = create_mock_http_response(EXAMPLE_EMBED_RESPONSE_JSON)
Expand Down
4 changes: 0 additions & 4 deletions tests/integrations/graphene/test_graphene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ def test_no_event_if_no_errors_async(sentry_init, capture_events):
FastApiIntegration(),
StarletteIntegration(),
],
data_collection={},
)
events = capture_events()

Expand Down Expand Up @@ -157,7 +156,6 @@ def test_no_event_if_no_errors_sync(sentry_init, capture_events):
GrapheneIntegration(),
FlaskIntegration(),
],
data_collection={},
)
events = capture_events()

Expand Down Expand Up @@ -185,7 +183,6 @@ def test_graphql_span_holds_query_information(sentry_init, capture_items):
integrations=[GrapheneIntegration(), FlaskIntegration()],
traces_sample_rate=1.0,
default_integrations=False,
data_collection={},
)
items = capture_items("span")

Expand Down Expand Up @@ -353,7 +350,6 @@ def test_breadcrumbs_hold_query_information_on_error(sentry_init, capture_items)
GrapheneIntegration(),
],
default_integrations=False,
data_collection={},
)
items = capture_items("span", "event")

Expand Down
7 changes: 0 additions & 7 deletions tests/integrations/httpx2/test_httpx2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def before_breadcrumb(crumb, hint):
sentry_init(
integrations=[Httpx2Integration()],
before_breadcrumb=before_breadcrumb,
data_collection={},
)

url = "http://example.com/"
Expand Down Expand Up @@ -72,7 +71,6 @@ def before_breadcrumb(crumb, hint):
sentry_init(
integrations=[Httpx2Integration()],
before_breadcrumb=before_breadcrumb,
data_collection={},
)

url = "http://example.com/"
Expand Down Expand Up @@ -187,7 +185,6 @@ def test_crumb_capture_client_error_sync(

sentry_init(
integrations=[Httpx2Integration()],
data_collection={},
)

url = "http://example.com/"
Expand Down Expand Up @@ -240,7 +237,6 @@ async def test_crumb_capture_client_error_async(

sentry_init(
integrations=[Httpx2Integration()],
data_collection={},
)

url = "http://example.com/"
Expand Down Expand Up @@ -1255,7 +1251,6 @@ def test_http_url_attributes_no_query_or_fragment_sync(
sentry_init(
integrations=[Httpx2Integration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("span")
Expand Down Expand Up @@ -1285,7 +1280,6 @@ async def test_http_url_attributes_no_query_or_fragment_async(
sentry_init(
integrations=[Httpx2Integration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("span")
Expand Down Expand Up @@ -1575,7 +1569,6 @@ def test_omit_url_data_if_parsing_fails(
sentry_init(
integrations=[Httpx2Integration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("span")
Expand Down
2 changes: 0 additions & 2 deletions tests/integrations/huggingface_hub/test_huggingface_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,6 @@ def test_chat_completion_api_error(
) -> None:
sentry_init(
traces_sample_rate=1.0,
data_collection={},
)

client = InferenceClient(model="test-model", provider="hf-inference")
Expand Down Expand Up @@ -1060,7 +1059,6 @@ def test_span_status_error(

sentry_init(
traces_sample_rate=1.0,
data_collection={},
)
items = capture_items("event", "span")

Expand Down
Loading
Loading