Repository navigation
test(clickhouse-driver, cohere, falcon, fastapi, fastmcp): Remove redundant empty data_collection from sentry_init - #7907
Open
ericapisani wants to merge 2 commits into
Conversation
…undant empty `data_collection` from sentry_init
Also covers google_genai, graphene, httpx2, huggingface_hub and langchain.
An empty `data_collection={}` is equivalent to the default, so the
argument is dropped from `sentry_init` in these tests.
Refs PY-2936
ericapisani
added this pull request to stack #7897
October 6, 2026 19:29
ericapisani
marked this pull request as ready for review
October 6, 2026 19:30
Contributor
Codecov Results 📊✅ 55349 passed | ⏭️ 2727 skipped | Total: 58076 | Pass Rate: 95.3% | Execution Time: 153m 49s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2061 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.38% 90.03% -0.35%
==========================================
Files 202 185 -17
Lines 26552 20672 -5880
Branches 9858 7116 -2742
==========================================
+ Hits 23997 18611 -5386
- Misses 2555 2061 -494
- Partials 1487 1216 -271Generated by Codecov Action |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs PY-2936