Repository navigation
Halt the tree and complete the execution when a node throws - #135
Closed
kineticsystem wants to merge 1 commit into
Closed
kineticsystem wants to merge 1 commit into
kineticsystem wants to merge 1 commit into
Conversation
When a node threw an exception while the tree was ticked, execute() aborted the goal and returned at once: the tree was not halted, and onTreeExecutionCompleted() was not called. Nodes still running, e.g. an action whose goal was sent, were left running, and a server that cleans up or reports the end of a run in onTreeExecutionCompleted() never learned that the run had ended. Halt the tree and call onTreeExecutionCompleted(FAILURE, false) there too, as for every other end of a run, for any exception thrown once onTreeCreated() has returned: by a node while the tree is ticked, or by onLoopAfterTick() or onLoopFeedback(). The result also carries the FAILURE node status. An exception thrown before, e.g. by the creation of the tree, is handled as before. If onTreeExecutionCompleted() itself throws while the execution is stopped, it is not called a second time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task done
Author
|
partial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a node threw an exception while the tree was ticked, execute() aborted the goal and returned at once: the tree was not halted, and onTreeExecutionCompleted() was not called. Nodes still running, e.g. an action whose goal was sent, were left running, and a server that cleans up or reports the end of a run in onTreeExecutionCompleted() never learned that the run had ended.
Halt the tree and call onTreeExecutionCompleted(FAILURE, false) there too, as for every other end of a run, once onTreeCreated() has been called for the goal. The result also carries the FAILURE node status. An exception thrown before, e.g. by the creation of the tree, is handled as before.