Repository navigation
Conversation
fspy benchmarklinuxmacoswindows |
wan9chi
added this pull request to stack #812
October 5, 2026 05:59
wan9chi
removed this pull request from stack #812
October 6, 2026 02:42
wan9chi
added this pull request to stack #813
October 6, 2026 02:42
Add e2e cases for uploads that the backend rejects, like the public cache service would: a token from a pull request's job, which the write policy doesn't allow, and an upload without a token from outside GitHub Actions. Both tasks succeed, and the run reports the upload as failed with the backend's message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
remote-cache-e2e-rejected-uploads
branch
from
October 6, 2026 02:48
f5802bf to
0514599
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With the write policy in place from #809, the e2e cases can cover the uploads the public cache service rejects. A developer running
--remote-cache=read-writeoutside GitHub Actions, or a job for a pull request, should still see their task succeed and be told why nothing was uploaded.Changes
pull_request_upload: a pull request's token doesn't satisfy the write policy. The upload gets403, and the details showWrite not permitted.upload_without_token: an upload from outside GitHub Actions has no token. It gets401, and the details showInvalid credentials.Both tasks succeed. The snapshots come from the file backend here. The backend switch later in this stack must leave them unchanged, which shows that the emulated policy matches the service.
Stacked on #809.
🤖 Generated with Claude Code