Skip to content

refactor(platform): Move GitRuntime into platform/git/exec as Runtime - #769

Open
manjari25 wants to merge 1 commit into
mainfrom
manjari/gitruntime-platform
Open

manjari25 wants to merge 1 commit into
mainfrom
manjari/gitruntime-platform

Conversation

@manjari25

Copy link
Copy Markdown
Contributor

Why?

The local workspace backend needs the same pinned runtime and scrubbed environment as the merger. This puts it in one shared place first.

What?

  • Move the pinned git runtime (GitRuntime) from the merger into platform/git/exec as Runtime, with Validate() and Command().
  • Switch the merger and the runway server wiring to gitexec.Runtime.
  • Move the runtime tests next to the code.
  • Validate now checks fields in a fixed order, so its error is deterministic. This is the only logic change.

Test Plan

  • bazel test //platform/git/... //runway/extension/merger/... //service/runway/...
  • make check-gazelle, make check-tidy and make lint pass

Issue

@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners October 2, 2026 19:54
// See the License for the specific language governing permissions and
// limitations under the License.

package gitexec

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am wondering if it needs to exit on it's own vs being part of the local gitworkspace impl itself ? do you see any use of it outside?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants