feat(platform): Refine gitworkspace contract with Skipped, cancellation and a failure helper - #768
Merged
Merged
Conversation
…on and a failure helper
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 2, 2026 19:13
behinddwalls
approved these changes
Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The OSS merger is being moved onto
Workspaceand will run batched command sequences. That needs an explicit skipped marker, unique aliases per batch, a shared way to produce classifiable errors, and cancellation that actually stops git.What?
Output.Skipped(replacing the ambiguous -1 exit code) and documents the rest of the contract: unique aliases per batch,Args[0]is the git subcommand, and cancelling theForcontext ends the workspace.CommandFailure(ctx, cmd, out), which builds a classifier-recognised error from a non-zeroOutput.localto setSkippedand kill git when theForcontext is cancelled.Test Plan
bazel test //platform/extension/gitworkspace/...make check-gazelle check-tidy lintgitworkspaceyet, so there's no behavior changeIssue