Repository navigation
Conversation
Generating a task graph creates millions of objects that stay alive until the end, so each collection traverses an ever growing heap without freeing anything. Disable the garbage collector while running each phase of the generator, restoring its previous state before yielding to the caller, and while loading a TaskGraph from JSON. Children loading kinds inherit the disabled collector, which also keeps them from writing to every page they share with the parent. Re-enabling the collector in children, or only freezing the heap after loading kinds and each phase (gc.freeze), measured slower in Firefox's taskgraph, with peak memory the same in all cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating a task graph creates millions of objects that stay alive until the end, so each collection traverses an ever growing heap without freeing anything. Disable the garbage collector while running each phase of the generator, restoring its previous state before yielding to the caller, and while loading a TaskGraph from JSON.
Children loading kinds inherit the disabled collector, which also keeps them from writing to every page they share with the parent.
Re-enabling the collector in children, or only freezing the heap after loading kinds and each phase (gc.freeze), measured slower in Firefox's taskgraph, with peak memory the same in all cases.