Repository navigation
Release 1.0.1: the Mac session (8.8) — and a reload kept no attributes, fixed - #38
Merged
Merged
Conversation
…ixed Run in Max on main, the suite found a second bug in 8.2's guard: the attributes the object adds for a class's fields answer their names in Max, so on a reload the guard took them for Max's own and reserved every field — a save left the object with no attributes. answered_by_max() now leaves out the object's own attributes as it did its own messages. The glue test's kernel answers an added attribute's name while a new scenario asks, and that scenario fails without the fix. The worker runtime test's console count was wrong, not the worker: the reload before `hang 1` begins a new load, so the hang is reported late again and, outlasting the ring, drops input too — it now expects each of the four lines. Whole suite: 12 patchers pass. The plan records 8.8's results and the stack measurement (512 KiB by default: about 98 levels of recursion through sorted's key; 16 MiB: CPython's own limit). CHANGELOG: 1.0.1 dated, with this fix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rVV9SkjkWmiBXFMT4whkz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mac session (plan 8.8), run in Max on main with 1.0.1's fix. It found a second bug in 8.2's reserved-name guard, which is fixed here. 1.0.1 is dated for release.
The bug
reloadfailed this way.worker'shangfailed the same way after its reload, with no message, because an unchanged file announces nothing.answered_by_max()now leaves out the object's own attributes, as it already did its own messages.The rest of 8.8
faultspasses: DSP toggled and a cord connected, with the C-argument names in the class.worker's console count was wrong, not the worker. The reload beforehang 1begins a new load, so the 500 ms hang is reported late again; it also outlasts the ring (latency plus 0.25 s), so input is dropped too. That's four lines, not two, and the test now expects each. It passed twice in a row.Whole suite: 12 patchers pass.
Stack measurement:
sorted's keypthread_attr_t, whatstd::threadgets)deep_recursion.py's 450threading.ThreaddoesStill by hand: the runbook's step 4 on the release packages, and Build Collective for
fileusage.Checked
After this merges, I'll tag
v1.0.1. From 1.0 on,release.ymlmakes a draft, so publishing is your step. Before you publish, I'll download the release's all-platform zip and run the suite on it.🤖 Generated with Claude Code
https://claude.ai/code/session_019rVV9SkjkWmiBXFMT4whkz