Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.01%
==========================================
Files 53 53
Lines 8381 8381
==========================================
+ Hits 7661 7662 +1
+ Misses 720 719 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1205.
Comparing
Translation,Scale, orAffineobjects with different axis counts can raise a NumPy broadcastingValueErrorbefore the axis comparison returnsFalse. Check the ordered axes before callingnp.allclose, preserving the existing type checks and numerical tolerances. Affine already validates matrix dimensions against its input/output axes during construction.Add 31 parameterized regression and control cases covering mismatched axis counts in both operand orders, independent Affine input/output mismatches,
==/!=, Sequence comparisons, numerical tolerances, axis order/names, and unrelated types.Validation on Linux, Python 3.12.15, NumPy 2.4.6, at
ea93a37203d187020c5d50a7f984dbf8c264a3ae:pytest -q -n 2 --dist worksteal --run-network: 1458 passed, 7 skipped, 2 xfailed. The skips and expected failures cover existing unsupported cases.pip check, andgit diff --check: passed.The full Python/OS/dependency matrix and the reported Xenium end-to-end workflow were not run locally.
AI assistance was used to prepare and validate this change.