Implement RFC8785 - #1091
Merged
Merged
Implement RFC8785#1091
Conversation
byroot
force-pushed
the
c14n
branch
2 times, most recently
from
October 2, 2026 13:51
9d0ecb9 to
9e51f22
Compare
Fix: ruby#1038 Directly lift https://github.com/dryruby/json-canonicalization At least for now, implementing most of the logic in Ruby make it shareable between the 3 generator implementations, largely reducing the maintenance cost. I don't particularly expect canonicalization to be a hotspot, but if it happens to be, I'd be open to specialize the implementation, within reason, at least in the C generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1038
Directly lift https://github.com/dryruby/json-canonicalization
At least for now, implementing most of the logic in Ruby make it shareable between the 3 generator implementations, largely reducing the maintenance cost.
I don't particularly expect canonicalization to be a hotspot, but if it happens to be, I'd be open to specialize the implementation, within reason, at least in the C generator.
TODO: