Repository navigation
Stop read() discarding frames whose data is all 0xFF - #3
Merged
Merged
Conversation
An unanswered header is reported by the device as a frame with recessive 0xFF data and SLV_NOT_RSP | TIMEOUT in the flags. read() treated that data pattern as an invalid read and returned None, so a passive logger never saw a single empty poll -- the master's polling cadence was invisible. The same check also hid any slave that legitimately answered with 0xFF bytes. read() now returns every record the driver queues (FRAME and the SLEEP / WAKEUP / OVERRUN events alike), returns None only for a non-blocking read that finds nothing or a short record, and no longer swallows every exception. Version 0.0.4. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unanswered header is reported by the device as a frame with recessive 0xFF data and SLV_NOT_RSP | TIMEOUT in the flags. read() treated that data pattern as an invalid read and returned None, so a passive logger never saw a single empty poll -- the master's polling cadence was invisible. The same check also hid any slave that legitimately answered with 0xFF bytes.
read() now returns every record the driver queues (FRAME and the SLEEP / WAKEUP / OVERRUN events alike), returns None only for a non-blocking read that finds nothing or a short record, and no longer swallows every exception. Version 0.0.4.