Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The scheduled
Monitor React Native New Issuesworkflow fails inExtract next oncallbecauseextractIssueOncalls.jsrequires an exact dated entry and theONCALL_SCHEDULEsecret has no entry for the active Tuesday.Live evidence:
99d327c613cdd4c3614cc3baa286a2d57a629136TypeError: Cannot read properties of undefined (reading '0')atschedule[dateStr][0]The exact-date lookup was introduced in
890b8f7ea3378685f7d6d9612ff584fc9ed17df0. The outage itself was triggered by the schedule crossing its final configured date, not by a new January commit, so a code bisection cannot isolate a later introducing commit.This change treats each dated rotation as effective until the next dated entry, which keeps issue monitoring alive when schedule maintenance is late. It writes a warning to stderr whenever it carries a rotation forward, so the stale configuration remains visible. Dates before the first configured entry still fail clearly.
Risk / limitation: until the secret is refreshed, the last configured pair remains on call. That is preferable to the current complete notification outage, but schedule owners should still update the secret.
Changelog:
[INTERNAL] [FIXED] - Keep issue monitoring running when the on-call schedule reaches its final dated entry.
Test Plan:
npx --yes jest@29.7.0 --runInBand --config '{"testEnvironment":"node","rootDir":"/tmp/react-native-ci-monitor/repo","transform":{}}' .github/workflow-scripts/__tests__/extractIssueOncalls-test.js— 9/9 tests passed, including the new expired-schedule regression case.npx --yes prettier@3.9.4 --check .github/workflow-scripts/extractIssueOncalls.js .github/workflow-scripts/__tests__/extractIssueOncalls-test.js— passed.node --checkon both changed files — passed.git diff --check— passed.Monitor React Native New Issuesworkflow-dispatch run on this branch — passed end to end: https://github.com/react/react-native/actions/runs/37396984698. The real secret took the carry-forward path, emitted the expected warning, and completedMonitor New Issuessuccessfully.A full workspace install was not run locally because the sparse diagnostic checkout cannot resolve unpublished
0.87.0-mainworkspace packages from npm; GitHub PR CI will exercise the repository-wide checks.