Repository navigation
config: preserve antiforgery tokens after boosted navigation - #71
Merged
Merged
Conversation
read_antiforgery() always returns an object, so boosted responses without metadata overwrite the saved token with empty values. Later POST requests that rely on automatic token injection can then fail antiforgery validation. Only update the saved configuration when the response contains a non-empty request token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A boosted navigation can return an HTML fragment without antiforgery metadata. The
htmx-toolkit.jsthen clears the previously saved token:A.Awith undefined.Only update the saved configuration when the response contains a non-empty request token. Otherwise, keep the previous values.