Skip to content

Update Ruff to 0.16.8 - #16468

Merged
AlexWaygood merged 1 commit into
mainfrom
alex/update-ruff-0-16-8
Oct 5, 2026
Merged

AlexWaygood merged 1 commit into
mainfrom
alex/update-ruff-0-16-8

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Update Ruff to 0.16.8, disabling its new RUF036 rule to avoid reordering existing unions and suppressing its new RUF068 rule where stubs mirror duplicate entries in reportlab's and workalendar's runtime __all__ tuples.

This is one of the dependencies that was updated in #16459.

Prepared with Codex.

@AlexWaygood
AlexWaygood marked this pull request as ready for review October 3, 2026 17:14
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau

srittau commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

@AlexWaygood Did you have a look at the instances flagged by RUF036? Is that something we should work towards fixing (I personally like that rule) or are there a significant amount of instances where fixing it would be detrimental? In the former case, we should leave a TODO comment and open an issue.

@AlexWaygood

AlexWaygood commented Oct 5, 2026 •

Copy link
Copy Markdown
Member Author

@AlexWaygood Did you have a look at the instances flagged by RUF036? Is that something we should work towards fixing (I personally like that rule) or are there a significant amount of instances where fixing it would be detrimental? In the former case, we should leave a TODO comment and open an issue.

Ugh, sorry, my PR description is terrible here. I should have checked the prose that codex wrote for me more carefully. I'm sorry 😞

I also think we should enable RUF036. I just wanted to separate enabling it into a standalone PR, since the diff is huge if we enable it here, and it makes it hard to spot the other changes being made here.

@srittau

srittau commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

I just wanted to separate enabling it into a standalone PR

I agree that that makes sense.

@AlexWaygood
AlexWaygood merged commit ff1d18c into main Oct 5, 2026
110 checks passed
@AlexWaygood
AlexWaygood deleted the alex/update-ruff-0-16-8 branch October 5, 2026 10:59
@AlexWaygood

Copy link
Copy Markdown
Member Author

#16477 for the followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants