Fix crash on unnormalized tuples in deferred type alias - #22096
Open
ilevkivskyi wants to merge 1 commit into
Open
ilevkivskyi wants to merge 1 commit into
ilevkivskyi wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21933
It is crucial that
TypeAliasnode is created once, and then modified in-place in case of deferrals. This is how recursive types were implemented, and a lot of code relies on this. However,rvalue.analyzed(ands.alias_nodefor new-style aliases) were getting a new alias node each time. And these are the waysMixedTraverserfinds type aliases to perform type normalization. Therefore, we could get non-normalized tuples (and other problematic types) in case of a deferred type alias.