Fix crash on invalid redefinition in dataclass - #22095
Open
ilevkivskyi wants to merge 4 commits into
Open
ilevkivskyi wants to merge 4 commits into
ilevkivskyi wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 3, 2026
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Both errors in |
Member
Author
|
Actually, I think the second one is wrong, we should expand the self-type there. |
Member
Author
|
OK, the situation is quite messy. So I will try to simply restore the existing behavior. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
After even more thinking, the dataclasses are different from regular classes in how they handle callables. So let's not go down this rabbit hole, and focus on simply fixing the crash. I will however keep all the tests fore future reference. |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
- tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20476
Fix seems to be quite simple: if there are some weird redefinitions, just ignore them, an error is already given.