Skip to content

chore(ci): setup netlify for simpler previews and remove circle ci - #817

Merged
InessaPawson merged 6 commits into
pyOpenSci:mainfrom
lwasser:netlify
Oct 8, 2026
Merged

InessaPawson merged 6 commits into
pyOpenSci:mainfrom
lwasser:netlify

Conversation

@lwasser

@lwasser lwasser commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

closes #816 This PR sets up Netlify in favor of CircleCI, which is clunky. It should also build only the languages that are currently published in the guide.

@netlify

netlify Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for python-package-guide ready!

Name Link
🔨 Latest commit 30dc56b
🔍 Latest deploy log https://app.netlify.com/projects/python-package-guide/deploys/6ac8016e6cf0b00008b1a391
😎 Deploy Preview https://deploy-preview-817--python-package-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@lwasser lwasser changed the title chore(ci): setup netlify for previews chore(ci): setup netlify for simpler previews and remove circle ci Oct 7, 2026
Comment thread CONTRIBUTING.md Outdated
@lwasser

lwasser commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

I will turn off circle ci once i see the preview here works. it's taking a while.

@lwasser
lwasser marked this pull request as ready for review October 7, 2026 23:20
@lwasser

lwasser commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Ok this is ready for review!! i deleted circle ci config and project settings.

Comment thread CONTRIBUTING.md Outdated
Comment thread netlify.toml

@InessaPawson InessaPawson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser Two admin items outside this PR (but related):

  • remove CIRCLECI_TOKEN from repo secrets
  • confirm no secrets are set as site-level env vars in the Netlify UI (see my comment #817 (comment))

@lwasser

lwasser commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

@InessaPawson I didn't set up any envt variables in Netlify or on GitHub for this to work that I know of. Do you know where to find that setting in Netlify? I don't see anything there in the setup . Circle CI tokens i can definitely delete. that's easy!!

@lwasser

lwasser commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

OK, CircleCI is deleted HERE, but we will need to delete it for other repos where I stripped CircleCI in favor of Netlify. The projects tho are deleted in CircleCI as well, so that helps.

@InessaPawson

Copy link
Copy Markdown
Contributor

@InessaPawson I didn't set up any envt variables in Netlify or on GitHub for this to work that I know of. Do you know where to find that setting in Netlify?

@lwasser On the PyOS Netlify dashboard, check:

Project configuration - Environment variables
Team settings - Environment variables

If both are empty, we are good.

@lwasser

lwasser commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

cool ok yes, both of those are empty. I never set anything up on Netlify. I think we are good to go here.

I deleted the CircleCI token, but we also have an organization-wide one that some projects used. I don't want to delete that token until we are sure no other repos depend on CircleCI.

But I've been deleting CircleCI projects as I remove the config and move the project to Netlify. Netlify authenticates via an app, so that makes things simple, and each time I add a new repo to Netlify to build, I just add that repo's permissions to Netlify!

Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
@InessaPawson
InessaPawson merged commit c57711b into pyOpenSci:main Oct 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup netlify for simpler previewing

2 participants