Repository navigation
chore(ci): setup netlify for simpler previews and remove circle ci - #817
Conversation
✅ Deploy Preview for python-package-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I will turn off circle ci once i see the preview here works. it's taking a while. |
|
Ok this is ready for review!! i deleted circle ci config and project settings. |
InessaPawson
left a comment
There was a problem hiding this comment.
@lwasser Two admin items outside this PR (but related):
- remove CIRCLECI_TOKEN from repo secrets
- confirm no secrets are set as site-level env vars in the Netlify UI (see my comment #817 (comment))
|
@InessaPawson I didn't set up any envt variables in Netlify or on GitHub for this to work that I know of. Do you know where to find that setting in Netlify? I don't see anything there in the setup . Circle CI tokens i can definitely delete. that's easy!! |
|
OK, CircleCI is deleted HERE, but we will need to delete it for other repos where I stripped CircleCI in favor of Netlify. The projects tho are deleted in CircleCI as well, so that helps. |
@lwasser On the PyOS Netlify dashboard, check: Project configuration - Environment variables If both are empty, we are good. |
|
cool ok yes, both of those are empty. I never set anything up on Netlify. I think we are good to go here. I deleted the CircleCI token, but we also have an organization-wide one that some projects used. I don't want to delete that token until we are sure no other repos depend on CircleCI. But I've been deleting CircleCI projects as I remove the config and move the project to Netlify. Netlify authenticates via an app, so that makes things simple, and each time I add a new repo to Netlify to build, I just add that repo's permissions to Netlify! |
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
closes #816 This PR sets up Netlify in favor of CircleCI, which is clunky. It should also build only the languages that are currently published in the guide.