Repository navigation
Conversation
thomasp85
added this pull request to stack #579
October 8, 2026 13:00
thomasp85
force-pushed
the
review/feedback
branch
from
October 8, 2026 13:13
a40d93e to
6f9236b
Compare
Call sites read fields off type_names() directly. Trait methods are now grouped into capabilities, types/identifiers, scalar translations, statement generators/DDL, and spatial sections.
…_prefix limits; evaluated test for case_greatest/case_least
thomasp85
force-pushed
the
review/feedback
branch
from
October 8, 2026 18:52
6f9236b to
6543208
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #578. Addresses the remaining review comments from @teunbrand on #569 that the earlier follow-ups didn't cover.
Trait cleanup (
SqlDialect)*_type_nameaccessors (number_type_name(), …) — call sites now readdialect.type_names().numberetc. directly, per the review suggestion.type_name_forstays as theCastTargetTypedispatcher.Behaviour changes
GREATEST/LEASTinstead of the CASE emulation (reviewer endorsed the version floor). Documented in the dialect's module docs; golden re-blessed.rewrite_namespaced_sqlquotes through the dialect instead ofnaming::quote_ident. Not load-bearing today (only DuckDB/SQLite call it), but removes the latent quoting bug.Naming
GgsqlParams→ConnectParams.Docs and tests
split_cte_prefixdocuments its machine-generated-input assumption: no T-SQL bracket identifiers, comments, or MySQL backslash escapes, andNoneconflates "no WITH" with "unparseable WITH".sql_st_*surface, above all reprojection, hasn't been verified against a live instance) and mark enabling as a follow-up.case_greatest/case_leastoutput against nativeGREATEST/LEAST, so the emulation is checked as executed SQL.Some((k, v)) => (k, Some(v.to_string())), simpler match arms).