Skip to content

Add truncate support. - #24289

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ginkgoch:lake-integration-support-truncate
Oct 9, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ginkgoch:lake-integration-support-truncate

Conversation

@ginkgoch

@ginkgoch ginkgoch commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

First-time contributors' checklist

What is changed, added, or deleted? (Required)

truncate ddl is supported, update the doc.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • Related code change PR links (if applicable):
  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated the SQL compatibility guide to list TRUNCATE as supported.

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2026
@ginkgoch
ginkgoch requested a review from sdojjy October 9, 2026 03:25
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

Walkthrough

The Lake SQL compatibility documentation now lists TRUNCATE as a supported DDL operation.

Changes

Lake SQL Compatibility

Layer / File(s) Summary
Update DDL support table
tidb-cloud/data-pipeline-lake-sql-compatibility.md
The DDL support table lists TRUNCATE as supported.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: 🔵 Low · up to eb92f

Confirm TRUNCATE support for the release-8.5 pipeline before relying on the new compatibility entry; document any version limit.

Architecture Summary

Architecture risk: 🔵 Low · up to eb92f

The change affects 1 system.

Changed systems: tidb-cloud

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tidb-cloud (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tidb-cloud/data-pipeline-lake-sql-compatibility.md: The DDL support table adds TRUNCATE with supported status.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the documented change: adding TRUNCATE support.
Description check Passed The description explains the documentation change and includes the required template sections. However, no affected TiDB version is selected, although the PR targets release-8.5.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

@sdojjy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f24475f1-5261-4801-bf7e-a613421bc2d0
📥 Commits

Reviewing files that changed from the base of the PR and between e8298fb and eb92fde.

📒 Files selected for processing (1)
  • tidb-cloud/data-pipeline-lake-sql-compatibility.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread tidb-cloud/data-pipeline-lake-sql-compatibility.md
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-09 05:02:09.276159948 +0000 UTC m=+361739.023390807: ☑️ agreed by qiancai.

@qiancai

qiancai commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Oct 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Oct 9, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit b1aae0b into pingcap:release-8.5 Oct 9, 2026
12 checks passed
@qiancai qiancai self-assigned this Oct 9, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Oct 9, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants