Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix increment/decrement expressions evaluate to the updated value. Their variable flow currently records only consumption of the mutation's inputs, leaving the new write marked unused even when it is returned, such as
return (string) ++$count.Record a target read after the prefix write, preserving the enclosing value-flow target. This also covers consumed array-offset mutations. Postfix expressions keep their existing pre-mutation input flow, and genuinely unused mutation results remain diagnosed. Mirror the change in the native handlers and bump the expected Turbo version.
Closes phpstan/phpstan#15411.
The regression retains the reported reproducer and covers decrement, assignment to a used result and array offsets. It fails with six unused-value diagnostics before the fix and passes after it.
Validation
UnusedVariableRuleTest: 33 tests / 33 assertions, with and without Turbo; includes existing unused prefix/postfix controls.ALL OK) and method/declaration parity on PHP 8.3 pass.Reproduce the rule regression with
php vendor/bin/phpunit tests/PHPStan/Rules/DeadCode/UnusedVariableRuleTest.php --filter testBug15411.