Conversation
The browscap loader rejects an entry that names itself as Parent, but a longer cycle such as A -> B -> C -> A loads fine, and get_browser() then followed it forever. get_browser() now records the entries it has visited and stops at the first repeat, so an entry in a cycle, or one whose chain leads into a cycle, still gets the properties of every distinct ancestor with the closest one winning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browscap loader already rejects an entry that is its own parent, but a longer cycle (A -> B -> C -> A) loads fine and get_browser() then follows it forever. get_browser() now remembers which entries it has visited and stops at the first repeat.