Conversation
devnexen
reviewed
Oct 5, 2026
IntlDateFormatter::parse(), localtime() and parseToCalendar() passed the PHP byte offset to ICU, which expects a UTF-16 code-unit position, and returned ICU's position unchanged. With multibyte text before the date, parsing started at the wrong place and the returned offset was too small. Convert the offset in both directions as phpGH-23094 did for NumberFormatter, and reject an offset that splits a UTF-8 sequence. A returned position inside a surrogate pair, which a partially matched literal can produce, maps to the start of that character. The offset helpers move into intl_convert.c and NumberFormatter now uses them too.
iliaal
force-pushed
the
fix/aph-intl-datefmt-offset-units-l91k-84-work
branch
from
October 5, 2026 11:34
dc74a76 to
c051104
Compare
devnexen
approved these changes
Oct 5, 2026
LamentXU123
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntlDateFormatter::parse(), localtime() and parseToCalendar() handed the PHP byte offset straight to ICU, which counts UTF-16 code units, so any multibyte text before the date made parsing start in the wrong place and the returned offset come back short (an emoji prefix parsed "2017-10-12" as year 17). This converts the offset both ways the same way GH-23094 did for NumberFormatter.