Conversation
php_xpath_eval() cleared the shared xmlXPathContext's node after every evaluation, and with registerNodeNS (the default) its namespace list as well. When a php:function() callback evaluated another expression on the same DOMXPath or Dom\XPath, the outer evaluation resumed without its context node and in-scope namespaces, so later predicate steps matched nothing or failed with "Undefined namespace prefix". The previous node and namespace list are now restored instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a php:function() callback evaluates another expression on the same DOMXPath or Dom\XPath, the inner evaluation used to clear the shared libxml context's node and namespace list on its way out, so the outer evaluation resumed without them: later predicate steps matched nothing or failed with "Undefined namespace prefix". php_xpath_eval() now restores the previous node and namespace list instead of clearing them.