Conversation
LSAPI_Write() returns either the full length or -1, but sapi_lsapi_ub_write() kept the result in an int and compared it with the size_t length, so -1 never took the error branch: a failed write was reported as complete and php_handle_aborted_connection() was not called. The short-write branch also returned str_length - ret instead of ret. The stdout fallback loop now counts in size_t and ssize_t as well. Fixes phpGH-23424
Member
|
@iliaal Did you test locally with litespeed? |
Member
Author
|
Yes, with OpenLiteSpeed 1.9.2 running lsphp in LSAPI mode, streaming 64 KB chunks and dropping the client mid-response. Without the patch connection_aborted() stays 0 after the failed write and the script runs to the end; with it the abort is flagged and the script stops. Full responses are identical on both builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up #23426, which fixed the short-write return value and was closed for inactivity. LSAPI_Write() only ever returns the full length or -1, and the -1 was the bigger problem: compared as an int against a size_t length it never took the error branch, so a failed write counted as complete. LiteSpeed is not built in CI; the file compiles cleanly with -Wsign-compare.
Fixes #23424