Conversation
A failure to escape an array or object key was ignored unless JSON_PARTIAL_OUTPUT_ON_ERROR was set, so encoding went on: later values still ran user code such as jsonSerialize(), and a later error replaced the one that was reported, e.g. a NAN value after an invalid UTF-8 key reported "Inf and NaN cannot be JSON encoded". Both key sites, the declared-property loop and the property table loop, now return FAILURE the same way a failed value does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an array or object key failed to encode, json_encode() carried on with the remaining values unless JSON_PARTIAL_OUTPUT_ON_ERROR was set, so
jsonSerialize()still ran on later values and a later error could replace the one that caused the failure. Both key sites now bail out the same way a failed value already does; partial output is unchanged.