Skip to content

fix: sort sparse coordinates when building a SparseVector from SciPy #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrikrah wants to merge 1 commit into from
Closed

fix: sort sparse coordinates when building a SparseVector from SciPy #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pgvector/sparsevec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,15 @@ def _from_sparse(self, arr: sparray | spmatrix, /) -> None:

if hasattr(value, 'coords'):
# scipy 1.13+
self._indices = value.coords[-1].tolist()
indices = value.coords[-1].tolist()
else:
self._indices = value.col.tolist()
self._values = [float(v) for v in value.data]
indices = value.col.tolist()

# coordinates are not necessarily ordered, and sparsevec requires ascending indices
elements = sorted(zip(indices, value.data))

self._indices = [int(v[0]) for v in elements]
self._values = [float(v[1]) for v in elements]

def _from_dense(self, value: list[float] | ndarray, /) -> None:
self._dim = len(value)
Expand Down
11 changes: 11 additions & 0 deletions tests/test_sparse_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,17 @@ def test_coo_array(self) -> None:
assert vec.indices() == [0, 2, 4]
assert isinstance(vec.values()[0], float)

def test_coo_array_unordered(self) -> None:
if np is None or sparse is None:
pytest.skip('NumPy and SciPy required')

arr = sparse.coo_array(([3, 1, 2], ([4, 0, 2],)), shape=(6,))
vec = SparseVector(arr)
assert vec.indices() == [0, 2, 4]
assert vec.values() == [1, 2, 3]
assert vec.to_text() == '{1:1.0,3:2.0,5:3.0}/6'
assert vec.to_binary() == pack('>iii3i3f', 6, 3, 0, 0, 2, 4, 1, 2, 3)

def test_coo_array_dimensions(self) -> None:
if np is None or sparse is None:
pytest.skip('NumPy and SciPy required')
Expand Down