Repository navigation
Metrics explorer page design - #3348
benjaminleonard wants to merge 40 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| * | ||
| * Exported for tests; use {@link oxqlAutocomplete} in the editor. | ||
| */ | ||
| export const oxqlCompletionSource = |
…query scope, datum
No point leaving it behind.
They're stable.
There is no such thing as "one representative query". There are three distinct kinds of charts, to say nothing of layout!
Codemirror was putting it behind the active line, making it challenging to see what text you selected (and impossible to tell what whitespace you selected).
This page is already tipped pretty far into "knowing everything about backend implementation details", so I'm just grabbing an easy win here.
Safari has subpixel precision on bounding boxes, so we need slightly more tolerance than exact matching for cursor<->placeholder comparisons. "Within a pixel" seems fair enough to me.
|
🤖 says we could cut over 90% of the timeseries schemas file checked in for mock purposes and still have the tests pass. Schema autocomplete in the editor in the mock version would be incomplete, but that's about the only practical difference. I'm inclined to cut just because the giant file is giant but there's no real need to do so. |
|
Couple thoughts here:
Mock data
Real data from dogfood
|
|
Relevant to the unit question — it would make things a lot easier if the metrics responses included units, but it looks like there's quite a lot required to get that done, at least according to the plan here: oxidecomputer/omicron#6696 It's possible we could do something clever client-side, though it would be fragile. I am not above fetching the units from the TOML in omicron and keeping a map of them. One issue would be that if you do some kind of math in your query and combine units, we might not be able to easily figure out what the resulting unit should be. |
Yeah... unfortunately this is intrinsic to oximeter at the moment. We could kind of... huck the schema TOML into console and pull out units that way (or, similarly, do that within omicron), but it's not in the DB schema at the moment.
We do have a "looks like a badge but doesn't screw with the casing" component now. I agree it's odd but my main concern (that you can copy-paste it with the correct casing) is satisfied, so I'm personally neutral on it.
Was a bit of laziness on my part; I think if you're transforming the table name at all, you should format it. Which is relatively a pain given how many acronyms we got floating around in here. Mono might be a good middle ground then (though my understanding is that it hurts @benjaminleonard's feelings) |
|
Example showing more aggressive UUID truncation. I felt like with truncating UUIDs to 24 chars, we were getting the visual noise of truncation without enough of the benefit in terms of space saved. 
|
|
Yeehaw. 
|
This branch was successfully deployed
3 participants
WIP