Repository navigation
fix(labrinth): reduce rows returned by project query - #7901
Merged
Merged
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
aecsocket
approved these changes
Oct 9, 2026
Contributor
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 13 minutes 26 seconds in the queue, including 13 minutes running CI. Required conditions to merge
|
6 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISTINCTdoesn't actually deduplicate anything. It returnsnumber of projects * versions per project * fields per versionrows.aggregate_version_fieldsinProjectQueryResultends up storing all fields for every version, which is then cached on Redis. For projects with 1000+ versions that's megabytes of data.The new query doesn't group by version ID, so duplicate rows are never fetched. The query plan is basically the same, only the amount of rows returned is reduced.
MIN(vf.version_id)isn't strictly necessary here but the type used (VersionField) actually needs a version ID field for other purposes. We could use a different type eventually but that's a bigger change. Loader fields will soon be removed anyways