Repository navigation
[Server] Fix outputSchema validation rejecting conforming structuredContent - #539
Open
chr-hertel wants to merge 4 commits into
Open
chr-hertel wants to merge 4 commits into
chr-hertel wants to merge 4 commits into
Conversation
A self-built JsonSerializable structuredContent and a nested empty object in a returned DTO conform as sent, but fail outputSchema validation.
Decoding an object result into arrays turned every nested {} into [], which
was sent as a JSON array and now fails outputSchema validation.
A self-built JsonSerializable value was validated by its properties, not by what it serializes to.
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 6, 2026 22:51
chr-hertel
added
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #515 - two cases were rejected although they conform on the wire:
CallToolResultwith aJsonSerializablevalue was validated by its properties instead of its serialization[], so it was sent as an array and failed validation