Repository navigation
[Client][Server] Negotiate 2026-07-28 across both eras on stdio and HTTP - #537
Open
chr-hertel wants to merge 12 commits into
Open
chr-hertel wants to merge 12 commits into
chr-hertel wants to merge 12 commits into
Conversation
2026-07-28 across both eras on stdio and HTTP
chr-hertel
marked this pull request as ready for review
October 6, 2026 23:04
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 6, 2026 23:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults the client to
2026-07-28and lets one client or server speak both eras on stdio and HTTP, following the backward compatibility rules of the spec.server/discoverand falls back toinitializeon2025-11-25unless the server proves to be modern -setFallbackProtocolVersion()picks the revision,nullmakes it modern-onlyStdioTransportsettles the era on the client's first request and serves2026-07-28incl.subscriptions/listenandnotifications/cancelled-32022naming the revisions on a bareinitialize, HTTP error statuses and a dead stdio process fail the request at oncesetLoggingLevel()rides on every request,ping()usesserver/discoverand the roots notification is skipped[BC Break] A default client against a dual-era server now lands on
2026-07-28, so sampling and roots are gone there - pinsetProtocolVersion(ProtocolVersion::V2025_11_25)to keep them.Server conformance runs at 100% locally for both revisions, client baselines pass.