Repository navigation
♻️ rename base response class - #361
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Public API changes break source and binary compatibility without compatibility support or an explicit breaking-release migration plan.
1 open finding
What changed in this PR
Harmonizes V2 SDK type names with other Mindee SDKs.
Changes:
- Renames
CommonResponsetoBaseResponsethroughout the response hierarchy and APIs. - Moves
FieldTypefromDynamicFieldto a standalone enum. - Updates CLI signatures and test references.
| File | Description |
|---|---|
| src/test/java/com/mindee/v2/product/ExtractionTest.java | Imports standalone FieldType. |
| src/test/java/com/mindee/v2/MindeeClientTest.java | Updates response types in test doubles. |
| src/main/java/com/mindee/v2/product/split/SplitResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/product/ocr/OcrResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/product/extraction/ExtractionResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/product/crop/CropResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/product/classification/ClassificationResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/parsing/search/BaseSearchResponse.java | Updates search response inheritance. |
| src/main/java/com/mindee/v2/parsing/LocalResponse.java | Updates deserialization bound and documentation. |
| src/main/java/com/mindee/v2/parsing/JobResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/parsing/inference/field/ObjectField.java | Uses standalone enum constants. |
| src/main/java/com/mindee/v2/parsing/inference/field/ListField.java | Updates object-field type comparison. |
| src/main/java/com/mindee/v2/parsing/inference/field/InferenceFields.java | Updates field-type comparisons. |
| src/main/java/com/mindee/v2/parsing/inference/field/FieldType.java | Defines standalone enum. |
| src/main/java/com/mindee/v2/parsing/inference/field/DynamicField.java | Removes nested enum. |
| src/main/java/com/mindee/v2/parsing/inference/FailedInferenceResponse.java | Extends BaseResponse. |
| src/main/java/com/mindee/v2/parsing/BaseResponse.java | Renames public response base class. |
| src/main/java/com/mindee/v2/MindeeClient.java | Updates response generic bounds. |
| src/main/java/com/mindee/v2/http/MindeeHttpApiV2.java | Updates HTTP implementation bounds. |
| src/main/java/com/mindee/v2/http/MindeeApiV2.java | Updates HTTP API contracts. |
| src/main/java/com/mindee/v2/cli/SplitCommand.java | Updates response signatures. |
| src/main/java/com/mindee/v2/cli/SearchRagDocumentsCommand.java | Updates output-handler signatures. |
| src/main/java/com/mindee/v2/cli/SearchModelsCommand.java | Updates output-handler signatures. |
| src/main/java/com/mindee/v2/cli/OcrCommand.java | Updates response signatures. |
| src/main/java/com/mindee/v2/cli/ExtractionCommand.java | Updates response signatures. |
| src/main/java/com/mindee/v2/cli/CropCommand.java | Updates response signatures. |
| src/main/java/com/mindee/v2/cli/ClassificationCommand.java | Updates response signatures. |
| src/main/java/com/mindee/v2/cli/BaseInferenceCommand.java | Updates abstract request return type. |
| src/main/java/com/mindee/v2/cli/BaseCommand.java | Updates shared output contracts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harmonize with other SDKs.
Types of changes