Skip to content

Optimize activation factory using binary search to make it 5x+ faster #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yexuan Xiao (YexuanXiao) wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Optimize activation factory using binary search to make it 5x+ faster #1633

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
842a9d9
Optimize activation factory using binary search
YexuanXiao Oct 4, 2026
100d5fe
Fix CI
YexuanXiao Oct 4, 2026
64dbcdd
Remove redundant function declarations
YexuanXiao Oct 4, 2026
0a8e136
Simplify code
YexuanXiao Oct 4, 2026
3caa8cb
Use std::find when the number of classes is le_eq to 32
YexuanXiao Oct 5, 2026
5f1d69f
Simplify code
YexuanXiao Oct 6, 2026
a19e6a1
Restore the name of write_component_activation
YexuanXiao Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 91 additions & 71 deletions cppwinrt/component_writers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,9 @@ namespace cppwinrt
return;
}

if (settings.component_opt)
{
auto format = R"(void* winrt_make_%();
)";

w.write(format, get_impl_name(type.TypeNamespace(), type.TypeName()));
}
else
{
auto format = R"(#include "%.h"
auto format = R"(#include "%.h"
)";

w.write(format, get_component_filename(type));
}
w.write(format, get_component_filename(type));
}

static void write_component_activation(writer& w, TypeDef const& type)
Expand All @@ -103,35 +92,16 @@ namespace cppwinrt
auto type_namespace = type.TypeNamespace();
auto impl_name = get_impl_name(type_namespace, type_name);

if (settings.component_opt)
{
auto format = R"(
if (requal(name, L"%.%"))
{
return winrt_make_%();
}
)";

w.write(format,
type_namespace,
type_name,
impl_name);
}
else
{
auto format = R"(
if (requal(name, L"%.%"))
{
return winrt::detach_abi(winrt::make<winrt::@::factory_implementation::%>());
}
auto format = R"(void* winrt_make_%()
{
return winrt::detach_abi(winrt::make<winrt::@::factory_implementation::%>());
}
)";

w.write(format,
type_namespace,
type_name,
type_namespace,
type_name);
}
w.write(format,
impl_name,
type_namespace,
type_name);
}

static void write_module_g_cpp(writer& w, std::vector<TypeDef> const& classes)
Expand All @@ -140,7 +110,61 @@ namespace cppwinrt
{
w.write_root_include("base");
}
auto format = R"(%

if (!settings.component_opt)
{
for (auto&& type : classes)
{
write_component_include(w, type);
}
}

std::vector<std::string> components;

for (auto&& type : classes)
{
if (!has_factory_members(w, type) || is_always_disabled(type))
{
continue;
}

std::string name{type.TypeNamespace()};
name += '.';
name += type.TypeName();
components.push_back(std::move(name));
}

// Sort the strings so that binary search can be used.
std::sort(components.begin(), components.end());
w.write("#define WINRT_ACTIVATION_TABLE(X)\\\n");

for (std::size_t i = 0; i + 1 < components.size(); ++i)
{
w.write(" X(winrt_make_%, L\"%\") \\\n", get_impl_name(components[i]), components[i]);
}

if (!components.empty())
{
w.write(" X(winrt_make_%, L\"%\") \n", get_impl_name(components.back()), components.back());
}

if (!settings.component_opt)
{
for (auto&& type : classes)
{
write_component_activation(w, type);
}
}
else
{
auto declarations = R"(
#define WINRT_DECLARE_FUNC(func, name) void* func();
WINRT_ACTIVATION_TABLE(WINRT_DECLARE_FUNC)
)";
w.write(declarations);
}

auto format = R"(
bool __stdcall %_can_unload_now() noexcept
{
if (winrt::get_module_lock())
Expand All @@ -154,20 +178,36 @@ bool __stdcall %_can_unload_now() noexcept

void* __stdcall %_get_activation_factory([[maybe_unused]] std::wstring_view const& name)
{
auto requal = [](std::wstring_view const& left, std::wstring_view const& right) noexcept
#if %
static constexpr std::wstring_view names[] =
{
return std::equal(left.rbegin(), left.rend(), right.rbegin(), right.rend());
#define WINRT_NAME_LIST(func, name) name,
WINRT_ACTIVATION_TABLE(WINRT_NAME_LIST)
};
%

using make_t = void* (*)();
static constexpr make_t makes[] =
{
#define WINRT_MAKE_LIST(func, name) func,
WINRT_ACTIVATION_TABLE(WINRT_MAKE_LIST)
};

#if % <= 32
auto it = std::find(std::begin(names), std::end(names), name);
if (it != std::end(names))
#else
auto it = std::lower_bound(std::begin(names), std::end(names), name);
if (it != std::end(names) && *it == name)
#endif
{
return makes[it - std::begin(names)]();
}
#endif
return nullptr;
}
)";

w.write(format,
bind_each<write_component_include>(classes),
settings.component_lib,
settings.component_lib,
bind_each<write_component_activation>(classes));
w.write(format, settings.component_lib, settings.component_lib, components.size(), components.size());

if (settings.component_lib != "winrt")
{
Expand Down Expand Up @@ -379,21 +419,8 @@ catch (...) { return winrt::to_hresult(); }
{
auto type_name = type.TypeName();
auto type_namespace = type.TypeNamespace();
auto impl_name = get_impl_name(type_namespace, type_name);

if (has_factory_members(w, type))
{
auto format = R"(void* winrt_make_%()
{
return winrt::detach_abi(winrt::make<winrt::@::factory_implementation::%>());
}
)";

w.write(format,
impl_name,
type_namespace,
type_name);
}
write_component_activation(w, type);

if (!settings.component_opt)
{
Expand Down Expand Up @@ -1210,14 +1237,7 @@ namespace winrt::@::implementation

static void write_component_cpp(writer& w, TypeDef const& type)
{
{
auto filename = get_component_filename(type);

auto format = R"(#include "%.h"
)";

w.write(format, filename);
}
write_component_include(w, type);

if (settings.component_opt)
{
Expand Down