Repository navigation
Conversation
`plugins/dsh` declared `@deepseek-ai/dsh-tools` only as an optional peer at `^0.1.0-rc.8` while importing it directly at runtime. That range admits neither `0.1.1-rc.2` nor `0.2.0-rc.2` (npm does not match prereleases of a tuple the range never names), so under the current harness the plugin's requirement conflicts with the tool runtime the harness installs: @deepseek-ai/dsh 0.2.0-rc.2 ships dsh-tools 0.2.0-rc.2. Declare it as a direct dependency with the range this plugin is tested against — `>=0.1.1-rc.2 <0.2.0 || >=0.2.0-rc.1 <0.3.0` — keeping the optional `cordis` peer, and align the package version and README prerequisites with the standalone dsh-skillopt package. No source change: `defineTool` is identical in both lines and the packed canary (40 checks) passes against dsh-tools 0.2.0-rc.2.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
plugins/dshwith the standalonedsh-skilloptpackage (WODE25500/dsh-skillopt), which is otherwise byte-identical to this directory apart from its own CI/CHANGELOG/lock.Problem.
plugins/dsh/package.jsonimports@deepseek-ai/dsh-toolsdirectly at runtime but declares it only as an optional peer at^0.1.0-rc.8. That range admits neither0.1.1-rc.2nor0.2.0-rc.2— npm does not match a prerelease whose[major, minor, patch]tuple the range never names — so the plugin's requirement conflicts with the tool runtime the harness installs.@deepseek-ai/dsh0.2.0-rc.2 (npmlatest/next) shipsdsh-tools0.2.0-rc.2, and0.1.5-rc.2ships0.1.1-rc.2.Change. Declare
@deepseek-ai/dsh-toolsas a direct dependency with the range this plugin is actually tested against:Two arms are needed: npm does not match prereleases of
0.2.0unless the range names that tuple with a prerelease, so<0.3.0alone still resolves to0.1.1-rc.2. The optionalcordispeer is unchanged. Package version and the README prerequisites line are aligned with the standalone package.No source change.
defineToolis byte-identical between the 0.1 and 0.2 lines (lib/index.jsexport list andschema.d.tsare the same), and the packed canary passes unchanged:node scripts/canary.mjs-> 40 checks,ALL CHECKS PASSEDagainstdsh-tools0.2.0-rc.2 (full peer tree,cordis4.0.4)0.1.1-rc.2->ALL CHECKS PASSED0.2.1-alpha.2(npmalpha, published 2026-10-09) also passes; it is intentionally left out of range because that line pairs with the prereleasecordis4.0.5-alpha.1, which the plugin does not claim yet.