Conversation
Co-authored-by: Codex <codex@openai.com>
4 of 7 tasks
rcosta358
added a commit
to liquid-java/liquidjava
that referenced
this pull request
Oct 6, 2026
## Description This PR adds a new `SMTUnknownError` instead of accepting refinements when Z3 returns `UNKNOWN`. Includes a reason hint and the refinement declaration location. Documentation update in [#6](liquid-java/liquidjava-docs#6). ## Example <img width="788" height="275" alt="image" src="https://github.com/user-attachments/assets/208938b5-3ca2-419d-a5b3-58662410c14d" /> ## Related Issue #303. It unexpectedly passes the verification because LJ reported unknown results as success. ## Type of change - [ ] Bug fix - [x] New feature - [ ] Documentation update - [ ] Code refactoring ## Checklist - [x] Added/updated tests under `liquidjava-example/src/main/java/testSuite/` (`Correct*` / `Error*`) - [x] `mvn test` passes locally - [x] Updated docs/README if behavior or API changed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
SMTUnknownErrorto the error table and explain that the diagnostic includes the reason as a hint.Validation: Jekyll build and
git diff --checkpass. Independent review found no issues.Related Issues
Related verifier change: liquid-java/liquidjava#330.
🤖 Generated with Codex