Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling
Group.Useafter registering a custom catch-allRouteNotFoundcurrently replaces that handler with the default 404. Preserve the successfully registered group route and its route-level middleware when rebuilding the catch-all with the latest group middleware. This also retains the route name, copies the middleware slice, and discards saved routes that have been removed.The regressions cover both catch-all paths, registration order, repeated
Use, rejected registrations, middleware order and ownership, disabled automatic registration, route removal, and an actual HTTP request with connection cleanup.Closes #3153.
Validation
f6051c1c9c844d35c88776fa45a3e657480f7c24: full race and coverage tests on Go 1.25.14 and 1.27.1, covering all three packages, with no failed or skipped tests.make check, explicitgolint -set_exit_status ./...,staticcheck ./...,go vet ./...,go test -short -count=1 ./...,govulncheck ./..., and changed-file gofmt checks pass.Hosted native validation and source hashes, benchmark comparison using the unchanged recorded measurements.