Document acquire-time profile binding for browser pools - #667
Draft
robertjamesprior wants to merge 1 commit into
Draft
robertjamesprior wants to merge 1 commit into
robertjamesprior wants to merge 1 commit into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser pools support loading a profile at acquire time, but only the changelog mentions it. The two guide pages that cover per-user pool profiles still teach the two-call flow — acquire, then
browsers.update— and the CLI reference doesn't list the flags the CLI already has.This documents the acquire-time path as the default:
browsers/pools.mdx— the per-user profiles section now binds the profile on the acquire call, with TypeScript/Python/Go examples updated. Notes that the profile loads before the browser is returned, thatsave_changesstill applies, and thatreusedoesn't (the lease always destroys the browser). Links to the post-create path for the case where a profile has to be attached to an already-running browser.browsers/profiles/concurrency.mdx— the per-user steps collapse from four to three.browsers/profiles/save-and-reuse.mdx— cross-link from "Load a profile after browser creation" to the acquire-time path.reference/cli/browser-pools.mdx— adds--profile-id,--profile-name, and--save-changestoacquire, and notes that--reusedoesn't apply to a lease carrying an acquire-time profile.Validation
mint broken-linksis the only CI check on this repo and no separate lint/build step exists; both anchors added here already exist and are referenced elsewhere in the docs. No preview run.Not in this PR
Two adjacent gaps I noticed and left alone:
acquireflag table is also missing--name,--start-url,--tag,--telemetry, and--telemetry-cdp-exclude, which the CLI accepts today.manage_browser_poolstool has noprofileparameter onacquire, so its reference correctly omits one. API/CLI parity for MCP would be a separate change.