Repository navigation
[bot] Merge master/0f69236e into rel/dev - #1854
Merged
Merged
Conversation
Langfuse v4 cannot add a label to an observation after it is created: the trace-create ingestion event stops working on 2026-11-16 and no endpoint updates an existing observation. A caller that wants its gen-ai traces grouped by combo or CI run therefore has to send the label with the request. ChatClient now reads GOODDATA_EVAL_TRACE_LABELS (key=value pairs, comma-separated) and sends them as a W3C baggage header on every chat request: each label as langfuse_metadata_<key>, and model_version also as langfuse_version, the dimension Langfuse groups cost by. gen-ai's Langfuse span processor copies langfuse_* baggage onto every span it starts, so the root generation, the cost-bearing children, retries and the title trace all carry the labels. Values are percent-encoded; OTel decodes them with unquote_plus, so '+' and spaces survive. Unset or empty sends no header, which keeps every existing run unchanged. Verified against gen-ai's own langfuse 4.14.4 SDK and FastAPI instrumentation: the header this builds lands as langfuse.version and langfuse.trace.metadata.* on both the root and the child generation. gen-ai only keeps caller langfuse_* baggage where genAi.langfuse.acceptCallerBaggage is on (gooddata/gdc-nas#27251). jira: GDAI-2547 risk: low
feat(gooddata-eval): label gen-ai traces through W3C baggage
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1854 +/- ##
===========================================
+ Coverage 84.17% 84.19% +0.01%
===========================================
Files 333 333
Lines 23235 23257 +22
===========================================
+ Hits 19559 19581 +22
Misses 3676 3676 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 0f69236 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/37587827818).