Repository navigation
fix: support iodata token values in Lexer.merge/1 - #76
Merged
josevalim merged 2 commits intoSep 28, 2026
Merged
Conversation
josevalim
reviewed
Sep 28, 2026
| @spec merge(list(T.token())) :: list(T.token()) | ||
| def merge([{tag, meta, value1}, {tag, meta, value2} | rest]), | ||
| do: merge [{tag, meta, value1 <> value2} | rest] | ||
| do: merge [{tag, meta, [value1, value2]} | rest] |
Collaborator
There was a problem hiding this comment.
Suggested change
| do: merge [{tag, meta, [value1, value2]} | rest] | |
| do: merge [{tag, meta, [value1 | value2]} | rest] |
javiergarea
force-pushed
the
fix/merge-iodata-token-values
branch
2 times, most recently
from
September 28, 2026 19:51
afcb6a2 to
fbc7ec7
Compare
Collaborator
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token values are documented as
iodata().merge/1joined them with<>, which only works on binaries.Merging binaries now returns an iolist.