Skip to content

Use StructArmed on QA - #471

Merged
arhimede merged 2 commits into
dotkernel:7.0from
samsonasik:use-structarmed-on-qa
Oct 1, 2026
Merged

arhimede merged 2 commits into
dotkernel:7.0from
samsonasik:use-structarmed-on-qa

Conversation

@samsonasik

Copy link
Copy Markdown
Contributor

This PR to make use of StructArmed.

This PR start apply StructArmed with initialize using PSR4 and CODEQUALITY preset. The CODEQUALITY fixes 22 violations:

- fn (RoleInterface $role): string => (string) $role->getName()->value,
+ static fn (RoleInterface $role): string => (string) $role->getName()->value,

applied with single command:

vendor/bin/structarmed analyze --fix

I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik

Copy link
Copy Markdown
Contributor Author

@arhimede ready for review 👍

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik

Copy link
Copy Markdown
Contributor Author

@arhimede I've fixed phpcs notice, it should be ready now 👍

@arhimede
arhimede requested a review from alexmerlin October 1, 2026 10:46
@arhimede
arhimede merged commit 813a223 into dotkernel:7.0 Oct 1, 2026
12 of 15 checks passed
@samsonasik
samsonasik deleted the use-structarmed-on-qa branch October 1, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants