Repository navigation
Correctness fixes: bits everywhere, exact Fischer/Krieger covers, and other bugs (1/5) - #17
Closed
Autoplectic wants to merge 3 commits into
Closed
Autoplectic wants to merge 3 commits into
Autoplectic wants to merge 3 commits into
Conversation
…act Fischer/Krieger covers - Report topological entropy, collision entropy, and HMM log-likelihoods in bits; model-selection criteria convert to natural logs to keep their standard scale. - Count ATTR_MULTIPLICITY in TMC adjacency matrices (entropy and Parry measure). - Raise instead of silently truncating SFT presentations at max_states. - Markov words of length 0 and sample_path respect the initial distribution. - Raise a clear error when sampling from an initial law with no mass. - Exact crypticity C_mu - E in block_entropy_estimates(use_exact=True). - Narrow broad except-Exception fallbacks that silently changed results. - equivalent() compares over the union of both automata's alphabets. - Exact right/left Fischer covers (Lind-Marcus convention: right = right-resolving) and new exact right/left Krieger covers. Co-authored-by: Cursor <cursoragent@cursor.com>
…bility data, Buchi empty loops - SlidingBlockCode.apply tracks the source presentation so constraints longer than the window survive, and rejects block maps that miss an allowed block. - Baum-Welch raises when every sequence is impossible and warns when some are. - Buchi lasso acceptance rejects an empty loop (not an omega-word). - suggest_lmax encodes symbols injectively instead of via repr. - Tests: Viterbi on impossible data, YAML round trips for every cover class and SymbolicModel. ALERGIA's Hoeffding test, SlidingBlockCode.compose, and TextileSystem.induced_code were checked and are correct as written. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Superseded by #22, which contains the same commits as a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of five stacked PRs from a full package review (see CHANGELOG.md in PR 5 for the migration table).
Tests, ruff, and sphinx -W pass.
Made with Cursor