Repository navigation
Pocket: skip removed Burrows when enabling push notifications - #1095
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
A Burrow the Relay's list no longer names keeps its paired record until Forget, so the Enable loop still registered it. Both Relays answer that pushSubscribe with 404 'unknown burrow', which threw partway through the loop, and the card counted the removed id among the Burrows that must be subscribed, so it could never reach 'on'.
Deploying mouseterm with
|
| Latest commit: |
c8cd7e9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8d9c1d16.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-pocket-push-skip-removed.mouseterm.pages.dev |
dormouse-bot
requested a deployment
to
hosted-preview
October 10, 2026 12:43 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Pocket's Burrows view, tapping Enable push notifications fails when the phone still holds a paired record for a Burrow the Relay no longer lists, which is a row showing Removed from your account or No longer enrolled with this Relay. This PR excludes those removed rows from push registration in both places that decide the push targets. A regression test covers it.
The Enable loop and the card's state picked targets with
!needsPairingonly. A removed row keeps its paired record until the user taps Forget, so it passed that filter. That broke push in two ways:onEnablePushcalledsubscribeToPushfor the removed Burrow. Both Relays refuse that with 404unknown burrow: the self-host one inrelay/src/app.ts, and the Hosted one inhosted/server/relay-push.ts. The 404 threw out of the loop, so Burrows after the removed one in the list were never registered, and the user saw an error.pushNoticeStaterequired every id inpairedBurrowIdsto be subscribed, and that list included the removed id, which can never be subscribed. The card therefore never reached "Push notifications on." and kept offering an Enable that could only fail.Both filters now use one predicate,
isPushTarget(paired and not removed).docs/specs/pocket-app.md→ "Detecting install state, and what cannot be detected" now says the tap registers the paired Burrows the Relay still lists.The new case in
App.push.test.tsxdropsburrow-1from the Relay's list. It asserts that onlyburrow-2is registered, that no error shows, and that the card reads on. It fails onmainand passes with this change, and the rest ofsrc/remote/pocket-app/passes too (173 tests).