fix(hub-ui): give dock iframes a title and the standalone hub landmarks - #425
Open
erkamyaman wants to merge 2 commits into
Open
erkamyaman wants to merge 2 commits into
erkamyaman wants to merge 2 commits into
Conversation
axe flags the standalone hub page for an unnamed dock iframe and for content outside any landmark. Each dock iframe now carries its localized dock title, and the dock list and content area are nav and main landmarks.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The navigation landmark label needs localization to match the selected UI language.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Improves accessibility in the standalone hub and dock iframes.
Changes:
- Adds localized iframe titles that follow UI language changes.
- Adds navigation and main landmarks, including for the authentication notice.
| File | Description |
|---|---|
packages/hub-ui/src/client/components/views/ViewIframe.vue |
Sets reactive, localized iframe titles. |
packages/hub-ui/src/client/components/dock/DockStandalone.vue |
Adds navigation and main landmarks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The nav landmark kept an English name when the UI switched language. It now uses the existing settings.docks translation.
8 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axe reports two violations on the standalone hub page (
/__devframes/), in both color schemes:frame-title: dock iframes have no accessible name.landmark-one-main/region: the page content is not inside any landmark.Changes:
ViewIframe.vue: each dock iframe gets its dock's title, localized withlocalizeTitle, and the title follows UI language changes.DockStandalone.vue: the dock list is a<nav aria-label="Docks">, and the content area and the auth notice are<main>.Checked with axe on the hub-ui playground in dark and light: both violations are gone with this change and present without it. Lint, build and the hub-ui tests (130) pass.