Skip to content

Remove stale xfail on schema-qualified INSERT parseutils test #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pacocartones wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove stale xfail on schema-qualified INSERT parseutils test #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0821f4b
Remove stale xfail on schema-qualified INSERT parseutils test
pacocartones Aug 28, 2026
18f469c
Document the still-needed xfail on the multi-column sub-select test
pacocartones Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/parseutils/test_parseutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ def test_simple_insert_single_table():
assert tables == ((None, "abc", "abc", False),)


@pytest.mark.xfail
def test_simple_insert_single_table_schema_qualified():
tables = extract_tables('insert into abc.def (id, name) values (1, "def")')
assert tables == (("abc", "def", None, False),)
Expand Down
7 changes: 6 additions & 1 deletion tests/test_sqlcompletion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,12 @@ def test_sub_select_col_name_completion():
}


@pytest.mark.xfail
@pytest.mark.xfail(
reason="Parsing an incomplete multi-column sub-select still misidentifies the "
"token before the trailing comma as a table: 'SELECT a, FROM abc' yields "
"table_refs for both 'a' and 'abc' instead of just 'abc'. Confirmed still "
"failing on sqlparse 0.6.0."
)
def test_sub_select_multiple_col_name_completion():
suggestions = suggest_type("SELECT * FROM (SELECT a, FROM abc", "SELECT * FROM (SELECT a, ")
assert set(suggestions) == cols_etc("abc")
Expand Down