Skip to content

validate arg indirect attribute before indexing direction array #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nussu06 wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −0
Open

validate arg indirect attribute before indexing direction array #8850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d61323b
validate arg indirect attribute before indexing direction array
Nussu06 Sep 13, 2026
6bb41b0
Merge branch 'main' into library-indirect-bounds
Nussu06 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/library.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,8 @@ Library::Error Library::loadFunction(const tinyxml2::XMLElement * const node, co
}
if (const char* const argIndirect = functionnode->Attribute("indirect")) {
const int indirect = strToInt<int>(argIndirect);
if (indirect < 0 || indirect >= static_cast<int>(ac.direction.size()))

@danmar danmar Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please suppress this

@Nussu06 Nussu06 Oct 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alert on this line is premium-cert-int31-c (I checked the SARIF from the PR's premium run), and that id is in cppcheckpremium-suppressions on main since #8915. An inline suppression would be redundant with that, so I merged main into the branch instead, which lets the Premium job pick up the updated list. No change to the diff itself. The workflow runs for the new push are waiting for approval, so I can't confirm the job is green yet. If you'd still prefer an inline cppcheck-suppress here, I'll add it.

return Error(ErrorCode::BAD_ATTRIBUTE_VALUE, argIndirect);
Comment thread
danmar marked this conversation as resolved.
ac.direction[indirect] = dir; // TODO: handle multiple directions/indirect levels
}
else
Expand Down
17 changes: 17 additions & 0 deletions test/testlibrary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,23 @@ class TestLibrary : public TestFixture {

// comma followed by dot
LOADLIB_ERROR_INVALID_RANGE("-10:0,.5:");

// arg indirect out of range (index into ArgumentChecks::direction)
LOADLIBERROR("<?xml version=\"1.0\"?>\n"
"<def>\n"
" <function name=\"foo\">\n"
" <arg nr=\"1\" direction=\"in\" indirect=\"1000000\"/>\n"
" </function>\n"
"</def>",
Library::ErrorCode::BAD_ATTRIBUTE_VALUE);

LOADLIBERROR("<?xml version=\"1.0\"?>\n"
"<def>\n"
" <function name=\"foo\">\n"
" <arg nr=\"1\" direction=\"out\" indirect=\"-5\"/>\n"
" </function>\n"
"</def>",
Library::ErrorCode::BAD_ATTRIBUTE_VALUE);
}

void loadLibCombinations() const {
Expand Down