Repository navigation
Conversation
A generic function is analyzed once per instantiation, but its basic block types were stored under its LocalDefId alone. Analyzing one instantiation from inside another (e.g. g::<i32> calling g::<i64>) overwrote the outer instantiation's blocks, so the outer analysis continued with the inner one's block types and predicate variables. This either panicked with "precondition is already registered for basic block" or silently verified the outer instantiation against the inner one's behaviour. Fixes #328 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3Dt425cRNNW8aSShzGyDA
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
A generic function is analyzed once per instantiation, but its basic-block types were stored under
LocalDefIdalone. When one instantiation was analyzed from inside another (for example,g::<i32>'s body callsg::<i64>), the nested run overwrote the outer run's block entries. The outer analysis then carried on with the inner instantiation's block types and predicate variables. Depending on the CFG, this either panicked withprecondition is already registered for basic blockor, with no error, verified the outer instantiation against the inner one's behaviour. In the second case, a panicking program verified assafe.Changes
Analyzer::basic_blocksis now keyed by(LocalDefId, GenericArgsRef<'tcx>). The register and lookup methods take the generic args.basic_block::Analyzertakes the instantiation'sgeneric_argsfromlocal_def::Analyzer, which already tracks them.fn_poly_nested_instantiation.rspass/fail UI test pair, built from the issue's reproducer. Onmainboth files get the wrong verdict (pass→Unsat,fail→safe).Validation
cargo test: all 396 UI tests pass, run with the pinned Z3 5.0.0 and PCSat wrapper.cargo clippy -- -D warningsandcargo fmt --all -- --checkare clean.W<W<i32>>delegating trait impl) now verifies, and its broken variant is rejected.🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3Dt425cRNNW8aSShzGyDA
Generated by Claude Code