Skip to content

feat(admin): NIP-11 vs probe mismatch warnings on Network Health - #799

Open
Ferryx349 wants to merge 2 commits into
mainfrom
feat/network-health-mismatch-warnings
Open

Ferryx349 wants to merge 2 commits into
mainfrom
feat/network-health-mismatch-warnings

Conversation

@Ferryx349

Copy link
Copy Markdown
Collaborator

Description

This PR adds mismatch detection on the latest Network Health snapshot (NIP-66 in supported_nips, NIP-42 auth vs NIP-11, public URL vs info.relay_url when self-monitoring a single target, plus PoW/payment info). GET /admin/network-health returns mismatches[] per probe target; the admin dashboard shows an Advertised vs observed list.

Related Issue

Closes #798

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

Annotate network-health snapshots with advertised vs observed mismatches
and surface them in the admin dashboard. Closes #798.
@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3d7b7c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 2/5

[Medium risk] Admin dashboard displays network health mismatch warnings.

The PR should not merge until false URL and authentication warnings and the misleading NIP-11 status override are corrected.

Findings

  1. P1 Mirror peers trigger URL warnings ▶
  2. P1 Publish authentication appears unadvertised ▶
  3. P1 Warnings mask failed NIP-11 checks ▶
  4. P2 Old snapshots use new settings ▶
Summary

The PR annotates the latest network-health snapshot with NIP-11 and probe comparisons, then displays those annotations in the admin dashboard.

  • Adds NIP-66, authentication, public-URL, PoW, and payment notices per target.
  • Adds controller and mismatch-helper tests.
  • The URL and authentication comparisons can produce false warnings, and warning styling can obscure a failed check.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Stored probe snapshot] --> C[Admin network-health controller]
  B[Current settings] --> C
  C --> D[Mismatch annotations per target]
  D --> E[Dashboard checks and warnings]
Loading

Reviews (1) · Last reviewed commit: "feat(admin): NIP-11 vs probe mismatch wa..."

Comment thread src/utils/network-health-mismatches.ts Outdated
Comment thread src/utils/network-health-mismatches.ts Outdated
Comment thread resources/admin/assets/dashboard.js Outdated
Comment thread src/controllers/admin/get-network-health-controller.ts Outdated
@coveralls

coveralls commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 72.685% (+0.1%) from 72.58% — feat/network-health-mismatch-warnings into main

Skip mirror peers for public-target checks, honor restricted_writes for
NIP-42, avoid masking failed NIP-11 status, and persist probeContext on snapshots.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Admin Console] NIP-11 vs probe mismatch warnings on Network Health

2 participants