Skip to content

Upgrade Thrift to 0.25.0 - #13

Merged
HTHou merged 2 commits into
mainfrom
codex/upgrade-thrift-0.25.0
Oct 5, 2026
Merged

HTHou merged 2 commits into
mainfrom
codex/upgrade-thrift-0.25.0

Conversation

@HTHou

@HTHou HTHou commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • upgrade the thrift dependency from 0.23 to 0.25
  • enable Thrift 0.25's optional rustls feature when this crate's tls feature is enabled
  • replace the local shared TLS stream adapter and manual handshake with TTlsClientChannel
  • preserve the existing system roots, custom CA, hostname override, insecure opt-out, mutual TLS, and TCP connect-timeout behavior
  • keep the existing uuid pin and update its compatibility comment for Thrift 0.25

Testing

  • cargo fmt --all -- --check
  • cargo test
  • cargo test --features tls
  • cargo clippy --all-targets -- -D warnings
  • cargo clippy --all-targets --features tls -- -D warnings

@HTHou
HTHou requested a balanced review from Copilot October 4, 2026 10:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The migration preserves existing TLS behavior and is covered by the established connection tests.

Review effort: Balanced
Findings: None

What changed in this PR

Upgrades Apache Thrift while adopting its native TLS transport without changing existing connection configuration.

Changes:

  • Upgrades Thrift from 0.23 to 0.25.
  • Enables Thrift’s optional rustls integration.
  • Replaces the custom shared TLS stream with TTlsClientChannel.
File Description
Cargo.toml Updates Thrift and TLS feature configuration.
src/​connection/​mod.rs Migrates TLS connections to Thrift’s native channel.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@HTHou
HTHou merged commit 54bfa1f into main Oct 5, 2026
7 checks passed
@HTHou
HTHou deleted the codex/upgrade-thrift-0.25.0 branch October 5, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants