Upgrade Thrift to 0.25.0 - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration preserves existing TLS behavior and is covered by the established connection tests.
Review effort: Balanced
Findings: None
What changed in this PR
Upgrades Apache Thrift while adopting its native TLS transport without changing existing connection configuration.
Changes:
- Upgrades Thrift from 0.23 to 0.25.
- Enables Thrift’s optional
rustlsintegration. - Replaces the custom shared TLS stream with
TTlsClientChannel.
| File | Description |
|---|---|
Cargo.toml |
Updates Thrift and TLS feature configuration. |
src/connection/mod.rs |
Migrates TLS connections to Thrift’s native channel. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thriftdependency from 0.23 to 0.25rustlsfeature when this crate'stlsfeature is enabledTTlsClientChanneluuidpin and update its compatibility comment for Thrift 0.25Testing
cargo fmt --all -- --checkcargo testcargo test --features tlscargo clippy --all-targets -- -D warningscargo clippy --all-targets --features tls -- -D warnings