Repository navigation
Release 3.1.0 - #58
Merged
Merged
Conversation
Minor, not major: the variable contract only grows. Six status tag colours join it, every default that moved is reachable through one of them, and nothing that worked against 3.0.0 stops working. What moved since 3.0.0: activeadmin-plugins#57 the theme switch no longer breaks the utility nav onto two lines activeadmin-plugins#56 status tag labels are white on darker fills, clearing 4.5:1 where the old pairing ran 2.35 to 3.78; column headings take the body text colour and line up with their own columns; the sort marker is drawn by the theme in currentColor instead of ActiveAdmin's grey sprite Upgrading gains a 3.1.0 section for the two colour changes, and the 3.0.0 one is corrected — it said two things had changed and then listed three. Both artefacts checked: the gem carries the stylesheet and the switch script, and npm run prepublishOnly + npm pack puts src/active_admin_theme.scss and src/theme_toggle.js in the tarball. The npm install snippet moves to ^3.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for what landed since 3.0.0.
Why minor
The variable contract only grows. Six status tag colours join it, every default that moved is reachable through one of them, and nothing written against 3.0.0 stops working. Appearance does change, so Upgrading gains a 3.1.0 section.
What is in it
display: flexon the list item fought ActiveAdmin'sli { display: inline }currentColorrather than ActiveAdmin's fixed grey spriterake cssalso grew three guards along the way: the README variables table is compared against the declarations in both directions, the status tag label contrast is computed from the shipped palette, and a block-level item in the utility nav fails the build.Checked
app/assets/stylesheets/wigu/active_admin_theme.scssandapp/assets/javascripts/wigu/theme_toggle.jsnpm run prepublishOnly && npm pack→src/active_admin_theme.scss,src/theme_toggle.jsThe npm install snippet in the README moves to
^3.1.0.Also
The 3.0.0 Upgrading section said two things had changed and then listed three. Corrected.